Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Jun 3, 2020

These are mostly Status APIs that now use Result.

@github-actions
Copy link

github-actions bot commented Jun 3, 2020

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Feels good to remove all this :-)

@pitrou pitrou closed this in ab93ba1 Jun 3, 2020
@kou
Copy link
Member

kou commented Jun 14, 2020

This breaks Turbodbc: https://github.com/dask/dask/blob/master/dask/dataframe/io/parquet/arrow.py#L9

Turbodbc uses Status AllocateResizableBuffer(MemoryPool* pool, ...): https://github.com/blue-yonder/turbodbc/blob/master/cpp/turbodbc_arrow/Test/tests/arrow_result_set_test.cpp#L113

@xhochy Could you change Turbodbc to use Result<std::unique_ptr<ResizableBuffer>> AllocateResizableBuffer(const int64_t size, MemoryPool* pool = NULLPTR)?

@xhochy
Copy link
Member

xhochy commented Jun 15, 2020

@kou Thanks for the heads-up, made a PR: blue-yonder/turbodbc#270

@kou
Copy link
Member

kou commented Jun 15, 2020

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants